Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve spring curve #507

Merged
merged 1 commit into from
Oct 18, 2024
Merged

feat: Improve spring curve #507

merged 1 commit into from
Oct 18, 2024

Conversation

tilucasoli
Copy link
Collaborator

Description

Improve SpringCurve, add a constructor using mass, stiffnessanddampingRatio. There is one other constructor which uses duration to do the curve calculation

Changes

  • Rewrite SpringCurve
  • Recreate some animations

Review Checklist

  • Testing: Have you tested your changes, including unit and integration tests for the affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

@vercel Vercel
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Oct 17, 2024 5:57pm

leoafarias
leoafarias approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leoafarias
leoafarias approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoafarias leoafarias merged commit 339a822 into main Oct 18, 2024
6 checks passed
@leoafarias leoafarias deleted the feat/spring-curve-improvements branch October 18, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoafarias leoafarias leoafarias approved these changes

Assignees
No one assigned
Labels
mix remix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tilucasoli @leoafarias